Closed kirkbyo closed 3 years ago
Okay this PR should be good to go now!
Let me know if you would like the approach revisited. Especially since this does not solve the root of the problem but as you mentioned, hopefully this solution will be short lived.
To use
ajv
for the upcoming https://github.com/andymatuschak/orbit/issues/184 PR, the latest version of typescript is required. I also went ahead and standardized the typescript version throughout all the packages.In the process of this upgrade it looks like Typescript is having trouble coercing
ActionLog
andPromptActionLog
as equivalent. Specifically, it looks like the taskParameters of RepetitionActionLog and taskParameters of PromptRepetitionActionLog is the property blocking this equivalency despite them being equivalent in theory. To circumvent this problem a force cast between the two types were introduced in the code.How I tested this?
yarn build
andyarn test
at the rootyarn run dev
for the backend to make sure the backend still compiled correctlyyarn sync
for thenote-sync
package to make sure its CLI was not affected.yarn storybook
for the UI