search

andymchugh / andrewbmchugh-flow-panel

Apache License 2.0
38 stars 2 forks source link

Put Plugin Zip Package To Repo's Release Tag #87

Closed emilyyujieli closed 3 months ago

emilyyujieli commented 4 months ago

Hi，

Background Latest release zip of flow panel is put in main branch, so we have to hardcode flow panel latest version in grafana helm chart, for example(https://github.com/andymchugh/andrewbmchugh-flow-panel/raw/main/**andrewbmchugh-flow-panel-1.16.1.zip)

Issue Every time flow panel release a new zip and the old version will be removed in main branch. it will cause Grafana not able to find original version's path and fail to start. helm chart are also not able to get the latest build zip automatically.

Question Whether it is possible to put the pre-build plugin zip package to repo's Release tag instead of in different branch. So the history version always exists, and we can also easily find the latest build and point to latest build zip.

andymchugh commented 4 months ago

I'd just assumed everyone pulled the panel from the grafana release space rather than my repo, but if people were using my repo they'd be pulling from a release branch. I've kept all the release branches in situ. i.e.

https://github.com/andymchugh/andrewbmchugh-flow-panel/raw/ver_1.14.0/andrewbmchugh-flow-panel-1.14.0.zip https://github.com/andymchugh/andrewbmchugh-flow-panel/raw/ver_1.16.1/andrewbmchugh-flow-panel-1.16.1.zip

Do you actually need all the release zips maintained in a folder on main or are the above branches sufficient? I'm open to changing things, just want to understand the problem first.

andymchugh commented 3 months ago

Not sure if the above answered it for you or not, but with no feedback I'll close out on the assumption that you are now happy. If the above doesn't solve it for you, do feel free to reopen it and we can continue to discuss.

emilyyujieli commented 3 months ago

Hi @andymchugh，

Thank you for your reply. We found this plugins now in grafana plugins space and seems we can use andrewbmchugh-flow-panel directly and then helm will go to grafana plugins space and pull down the latest zip, l will check on that and this requirement is no needed now.