search

andymeneely / chromium-history

Scripts and data related Chromium's history
11 stars 4 forks source link

Metric: Number of Security-Experienced Participants #113

Closed andymeneely closed 10 years ago

andymeneely commented 10 years ago

The method should be CodeReview#security_exp_participants.

The method should return an array or ActiveRecord::Relation of developers, not just the number since we'll need to aggregate this over files.

The method should return participants. My reasoning: for this metric, anyone who has security experience can potentially provide security input no matter what their role in the code review was, but they had to provide input (even an LGTM) for that knowledge to transfer. Even a reviewer who just LGTMs with security experience is fine, so we don't need to use contributors.

Definition: a security-experienced participant is one who has been a participant of a prior security-fixing code review. Check the start dates of the code reviews on both sides of that.

cketant commented 10 years ago

i could take this as it is similar to #103

andymeneely commented 10 years ago

Oops accidentally hit the closed button.

cketant commented 10 years ago

Is this enhancement identical to #103 for vulnerability_inspectors for Filepath?

cketant commented 10 years ago

Working on stats and verifies for this now.

cketant commented 10 years ago

Meeting with @bspates to optimize this. Very Slow.