search

andymeneely / chromium-history

Scripts and data related Chromium's history
11 stars 4 forks source link

Commit Filepaths not being Associated with code reviews #121

Closed bspates closed 10 years ago

bspates commented 10 years ago

I am not sure if this is only in development, but I am getting failed tests for the relationship between issue 10854242, and the file path ui/base/x/x11_util.cc. This causes the reviewers to file path verify to fail, as well as the count for file path consolidation.

andymeneely commented 10 years ago

Hm, I'm not getting this. Can you copy in your error?

bspates commented 10 years ago

Executing Run:Verify.

verify_all_cves_have_one_issue [PASS] verify_no_plusses_email [PASS] verify_no_g_tmp_emails [PASS] verify_commit_files_have_no_ellipses [PASS] verify_commit_files_have_no_trailing_spaces [PASS] verify_commit_files_have_no_leading_spaces [PASS] verify_filepaths_are_present [PASS] verify_dangling_comments [PASS] verify_dangling_messages [PASS] verify_dangling_patch_set_files [PASS] verify_dangling_patch_sets [PASS] verify_dangling_commit_files [PASS] verify_reviewers_for_filepath [FAIL] Expected: ["agl@chromium.org", "ben@chromium.org", "darin@chromium.org", "derat@chromium.org", "kbr@chromium.org", "sadrul@chromium.org"], Actual: [], verify_filepath_vulnerable [FAIL] Expected: true, Actual: false, verify_filepath_neutral [PASS] verify_participants_for_code_review [PASS] verify_participants_for_dev [PASS] verify_code_review_10854242_reviewers [PASS] verify_code_review_10854242_reviewers [PASS] verify_code_review_10854242_owner [PASS] verify_commit_belongs_to_code_review [PASS] verify_code_review_has_one_commit [PASS] verify_10854242_1_1_churn [PASS] verify_10854242_1_churn [PASS] verify_10854242_total_churn [PASS] verify_10854242_max_churn [PASS] verify_10854242_no_overlooked_patchsets [PASS] verify_9141024_overlooked_patchsets [PASS] verify_10854242_num_nonparticipating_reviewers [PASS] verify_reviewers_for_6eebdee [PASS] verify_reviewers_for_6eebdee [PASS] rake aborted! undefined method cve?' for nil:NilClass /home/vagrant/chromium-history/lib/chromium_history/verify/development/commit_association_verify.rb:11:inverify_commit _filepath_to_cve' /home/vagrant/chromium-history/lib/chromium_history/verify/verify_base.rb:6:in block in run_all' /home/vagrant/chromium-history/lib/chromium_history/verify/verify_base.rb:5:ineach' /home/vagrant/chromium-history/lib/chromium_history/verify/verify_base.rb:5:in run_all' /home/vagrant/chromium-history/lib/chromium_history/verify/verify_runner.rb:38:inblock in run_verify' /home/vagrant/chromium-history/lib/chromium_history/verify/verify_runner.rb:35:in each' /home/vagrant/chromium-history/lib/chromium_history/verify/verify_runner.rb:35:inrun_verify' /home/vagrant/chromium-history/lib/chromium_history/verify/verify_runner.rb:16:in run_all' /home/vagrant/chromium-history/lib/tasks/run.rake:67:inblock (2 levels) in <top (required)>' /usr/local/rvm/gems/ruby-2.1.0/bin/ruby_executable_hooks:15:in eval' /usr/local/rvm/gems/ruby-2.1.0/bin/ruby_executable_hooks:15:in

' Tasks: TOP => run => run:verify (See full trace by running task with --trace)

bspates commented 10 years ago

And this is on my working branch and on master with an empty working copy

bspates commented 10 years ago

Also I queried the association between commit_filepath and filepath for the one i mentioned above and the filepath wasn't in commit_filepath, but it was in patchset_file.