andymeneely / chromium-history

Scripts and data related Chromium's history
11 stars 4 forks source link

"Path doesn't exist" Errors in first-ownership script #209

Closed rikal closed 9 years ago

rikal commented 9 years ago

@andymeneely 2 Types of errors when doing git show SHA:file in script #192, with sample output for git show -M --name-status SHA:

Fatal: Path 'file' does not exist in 'SHA'

fatal: Path 'webkit/appcache/OWNERS' exists on disk, but not in '38652ccc387015d2823bff91c76b3afd636befe7'.
fatal: Path 'webkit/database/OWNERS' exists on disk, but not in '38652ccc387015d2823bff91c76b3afd636befe7'.
fatal: Path 'webkit/quota/OWNERS' does not exist in '38652ccc387015d2823bff91c76b3afd636befe7'
commit 38652ccc387015d2823bff91c76b3afd636befe7
Author: jamesr@chromium.org <jamesr@chromium.org@0039...98>
Date:   Thu May 9 21:29:58 2013 +0000

    Add michaeln to webkit/OWNERS and clean house

    This moves Michael up to the root webkit/OWNERS file and removes redundant
    OWNERS in subdirectories. Otherwise the new directory structure is going to
    be a pain in the rear.

    BUG=239107
    NOTRY=true
    Review URL: https://chromiumcodereview.appspot.com/14744014
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19etc...

M       webkit/OWNERS
D       webkit/appcache/OWNERS
M       webkit/blob/OWNERS
M       webkit/chromeos/OWNERS
D       webkit/database/OWNERS
M       webkit/dom_storage/OWNERS
M       webkit/fileapi/OWNERS
D       webkit/quota/OWNERS
fatal: Path 'components/autofill/common/OWNERS' does not exist in 'd04f8191fdd43c456119595c4a3a7d5d8bc7c42b'
commit d04f8191fdd43c456119595c4a3a7d5d8bc7c42b
Author: blundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Tue Jun 18 14:52:13 2013 +0000

    In components/autofill, move common/ to core/common/

    This change is part of moving autofill into its eventual structure of a layered
    component. autofill/components/core/ is a new directory that will hold code
    that is shared by all platforms (including iOS). This CL moves autofill/
    components/common/ underneath this directory; a follow-up CL will move
    autofill/components/browser underneath this directory as well.

    This CL additionally imposes the correct DEPS restrictions on
    autofill/components/core/, with temporary allowances for the current
    violating includes.

    TBR=joi, thakis, benm
    BUG=247015
    Review URL: https://chromiumcodereview.appspot.com/16879006
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206...951-d872f2087c98

R100    components/autofill/common/OWNERS       components/autofill/core/common/OWNERS

Fatal: Path 'file' exists on disk, but not in 'SHA'

commit b9681b31f050a38641bbcf970b8437b4ba02db4e
Author: tfarina <tfarina@chromium.org>
Date:   Fri Oct 10 20:58:02 2014 -0700

    webkit: Remove OWNERS file from layout_tests/ directory.
    I haven't delete it in https://chromium.googlesource.com/chromium/src/+/a1etc... 
    to mute the presubmit check.
    Now that the change is landed, we don't need this OWNERS file anymore
    and we can just remove it.

    BUG=338338
    TEST=None
    TBR=dpranke@chromium.org
    NOTRY=true
    Review URL: https://codereview.chromium.org/651463005
    Cr-Commit-Position: refs/heads/master@{#299234}

D       webkit/tools/layout_tests/OWNERS
commit 42b79565bd702fa7bd46b9545a73c2852255be23
Author: tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Tue Feb 22 23:32:38 2011 +0000

    WebUI: Move chrome/browser/dom_ui/ to chrome/browser/webui/.
    To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/.
    I'll updated the references and delete the stub files later.

    BUG=59945, 59946
    TEST=trybots
    Review URL: http://codereview.chromium.org/6538075
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@etc...

R100    chrome/browser/dom_ui/OWNERS    chrome/browser/webui/OWNERS
commit 29e2fb456d3bf933168cf24bccaf05b1bea862fc
Author: jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Fri Jul 19 01:13:47 2013 +0000

    Move NPAPI implementation out of webkit/plugins/npapi and into content.

    Notes:
    -gtk_plugin_container_manager* and gtk_plugin_container* move to ...
    -a few constants moved from plugin_constants_win.h to plugin_util.h temporarily

    BUG=237249
    TBR=scottmg
    Review URL: https://codereview.chromium.org/19761007
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@etc...

R100    webkit/plugins/npapi/OWNERS     content/child/npapi/OWNERS
rikal commented 9 years ago

Also seems like most of these directory changes/reorganizations happened after release 11, so they're to be taken into account for later ownership changes