andymeneely / chromium-history

Scripts and data related Chromium's history
11 stars 4 forks source link

Better handling of filepaths #53

Closed andymeneely closed 10 years ago

andymeneely commented 10 years ago

Create a new Filepath model that has a many-many relationship with Commit. The CommitFile model no longer needs to exist, and the table is just a linking table. Create the association has_many in Commit using the :through option.

cketant commented 10 years ago

To Confirm: The Filepath model will have only an id and a varchar of the path? The CommitFile model will be a join table? Joining a commit with a Filepath with the following attributes: an id, commit_id, and a Filepath_id?

andymeneely commented 10 years ago

Yes on all questions

dani5447 commented 10 years ago

@cck9672 Have you done anything on this recently? I'm wondering because I've been setting up for the issue Prof Meneely mentioned in the above comment. I have a file called verify_Filepath_vulnerable set up in chromium-history\lib\chromium_history\verify now.

cketant commented 10 years ago

see #63