andymeneely / chromium-history

Scripts and data related Chromium's history
11 stars 4 forks source link

Verify filepath parsing #54

Closed andymeneely closed 10 years ago

andymeneely commented 10 years ago

Write a verify task that checks that each file is actually a filepath. Not sure how to do this, but perhaps no spaces and allow only certain characters. We need some assurance that our filepaths are getting parsed up correctly.

cketant commented 10 years ago

To check the file path integrity looking for the following: spaces, ellipses (git causes relative paths in certain cases i think), and looking into to actually verifying the path of the commit file as stored in the db against the actual path on chromium server.

andymeneely commented 10 years ago

Make sure the test only looks for files that cannot begin or end with spaces. But we strip on the loader anyway, so we probably don't need to check spaces

andymeneely commented 10 years ago

With the new parsing logs generated from c32053be0edea19f0d71ad01b32d0ae4e05121e5, this is no longer needed.