search

andymeneely / chromium-history

Scripts and data related Chromium's history
11 stars 4 forks source link

Schema fixes #79

Closed toroidal-code closed 10 years ago

toroidal-code commented 10 years ago

Removed the on_optimize functions from the models. We really should not be dynamically adding optimizations using reflection from rake:run, as these optimizations are also (intended to be) shown in the schema, (which is what is loaded with rake db:reset), and are designed to be created with ActiveRecord Migrations.

Also, dropped reviewers field from the Commit model. Fixes #76 Requesting @andymeneely take a look at this.

andymeneely commented 10 years ago

Actually, I want to keep the on_optimize. We deviated from the typical methods intentionally because we're doing batch processing. Since we load data all at once, we want to load it without indexes so (a) loads run faster, and (b) the indexes remain compacted. So let's keep that. I'm okay with the other two commits, though. Open a new pull request for it.

toroidal-code commented 10 years ago

I'm having a problem where I'll create the migration, and when I run it, the schema changes are there because of migrate running rake db:schema:dump, do you want me to just not commit that file?