Closed andymeneely closed 10 years ago
As of our most recent revision 1eab2b5, if I remove the current failing test in #81 and do a rake run, it fails. Here are the reproducing steps:
$ rm lib/chromium_history/verify/filepath_verify.rb $ rake run Env.: development Data: data/development Database: chromium_dev Start: 2014-02-17 16:56:41 -0500 -- enable_extension("plpgsql") -> 0.0365s -- create_table("ccs", {:force=>true}) -> 0.0470s -- create_table("code_reviews", {:force=>true}) -> 0.0560s -- create_table("comments", {:force=>true}) -> 0.0247s -- create_table("commit_filepaths", {:id=>false, :force=>true}) -> 0.0156s -- create_table("commit_files", {:force=>true}) -> 0.0265s -- create_table("commits", {:force=>true}) -> 0.0475s -- create_table("commits_filepaths", {:force=>true}) -> 0.0201s -- create_table("cves", {:force=>true}) -> 0.0184s -- create_table("developers", {:force=>true}) -> 0.0387s -- create_table("filepaths", {:force=>true}) -> 0.0109s -- create_table("messages", {:force=>true}) -> 0.0368s -- create_table("patch_set_files", {:force=>true}) -> 0.0934s -- create_table("patch_sets", {:force=>true}) -> 0.0344s -- create_table("reviewers", {:force=>true}) -> 0.0185s -- initialize_schema_migrations_table() -> 0.0158s user system total real Loading code reviews: 1.050000 0.030000 1.080000 ( 1.305939) Loading CVE number and reviews: Review Number 10854242 is not in our database. 0.020000 0.000000 0.020000 ( 0.018373) Loading git log commits: 0.300000 0.020000 0.320000 ( 0.477621) user system total real Executing on_optimize... 0.020000 0.000000 0.020000 ( 0.290546) Executing Run:Verify. verify_code_reviews_and_cves_relationship [PASS] verify_dangling_comments [PASS] verify_dangling_messages [PASS] verify_dangling_patch_set_files [PASS] verify_dangling_patch_sets [PASS] verify_dangling_commit_files [PASS] verify_no_plusses_email [PASS] verify_number_of_code_reviews [FAIL] Less than 6 Code Reviews found. Actual: 5 verify_number_of_patchsets [FAIL] Less than 18 Patch Sets found. Actual: 14 verify_number_of_comments [FAIL] Less than 14 Comments found. Actual: 12 verify_number_of_commits [PASS] verify_number_of_messages [FAIL] Less than 75 Messages found. Actual: 52 verify_number_of_patch_set_files [FAIL] Less than 72 Patch Set Files found. Actual: 61 rake aborted! undefined method `messages' for nil:NilClass /home/axmvse/chromium/history/lib/chromium_history/verify/development/load_complete_verify.rb:108:in `helper_count_messages' /home/axmvse/chromium/history/lib/chromium_history/verify/development/load_complete_verify.rb:30:in `verify_code_review_10854242_has_23_messages' /home/axmvse/chromium/history/lib/chromium_history/verify/verify_base.rb:6:in `block in run_all' /home/axmvse/chromium/history/lib/chromium_history/verify/verify_base.rb:5:in `each' /home/axmvse/chromium/history/lib/chromium_history/verify/verify_base.rb:5:in `run_all' /home/axmvse/chromium/history/lib/chromium_history/verify/verify_runner.rb:38:in `block in run_verify' /home/axmvse/chromium/history/lib/chromium_history/verify/verify_runner.rb:35:in `each' /home/axmvse/chromium/history/lib/chromium_history/verify/verify_runner.rb:35:in `run_verify' /home/axmvse/chromium/history/lib/chromium_history/verify/verify_runner.rb:16:in `run_all' /home/axmvse/chromium/history/lib/tasks/run.rake:56:in `block (2 levels) in <top (required)>'
As of our most recent revision 1eab2b5, if I remove the current failing test in #81 and do a rake run, it fails. Here are the reproducing steps: