search

andymeneely / chromium-history

Scripts and data related Chromium's history
11 stars 4 forks source link

Metric: Number of non-participating reviewers #99

Closed andymeneely closed 10 years ago

andymeneely commented 10 years ago

Reviewers and Participants are not subsets of each other - you can be a reviewer and never participate and you can be a participant but not a reviewer.

Reviewers who don't participate can be a problem because you were not just put there to be notified, you were given authority to stamp it as ok or not. So, participation is probably expected.

A high number of non-participating reviewers could be an indication of a poor review.

So, let's make this a method for CodeReview.

dani5447 commented 10 years ago

Wrote the method in CodeReview, added a verify, and added it to the rake run:stats output. Is there anything else that should be done with this?

andymeneely commented 10 years ago

Passes on my box. LGTM.