andymeneely / squib

A Ruby DSL for prototyping card games.
http://squib.rocks
MIT License
918 stars 67 forks source link

fix save_sheet to calculate rows correctly based on range #207

Closed sparr closed 7 years ago

sparr commented 7 years ago

Saving a sheet with a range of cards leads to empty rows. This patch adjusts the calculation to be based on the size of the range, which is the number of cards that will actually get rendered.

sparr commented 7 years ago

Also, this incorporates my previous bugfix, because I'm too lazy to manage that level of merge conflicts in PRs.

I can add a unit test for the size of a sheet made from a range, if desired.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-6.0%) to 93.671% when pulling 2cb122577f90ec4d6ec6b71f881dfd1db66c8c74 on sparr:BUGFIX-savesheet_range into 566d0dfaca48eb1bde88ad4b474973153ac7ef08 on andymeneely:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-6.0%) to 93.671% when pulling 2cb122577f90ec4d6ec6b71f881dfd1db66c8c74 on sparr:BUGFIX-savesheet_range into 566d0dfaca48eb1bde88ad4b474973153ac7ef08 on andymeneely:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.0003%) to 99.64% when pulling 33091ad44e72be44fe25b77b7d113c8bb6e84b03 on sparr:BUGFIX-savesheet_range into 566d0dfaca48eb1bde88ad4b474973153ac7ef08 on andymeneely:master.

andymeneely commented 7 years ago

Yes! Been meaning to fix this behavior. I'll mess around with this solution and see how it works.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.004%) to 94.436% when pulling a9574500115a5531b6af8b670721447b6b06d1e1 on sparr:BUGFIX-savesheet_range into 6149023dbbac48db98d2c96b9f947f926b4916a8 on andymeneely:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.004%) to 94.436% when pulling a9574500115a5531b6af8b670721447b6b06d1e1 on sparr:BUGFIX-savesheet_range into 6149023dbbac48db98d2c96b9f947f926b4916a8 on andymeneely:master.

andymeneely commented 7 years ago

Merged! Thanks again.