andymeneely / squib

A Ruby DSL for prototyping card games.
http://squib.rocks
MIT License
918 stars 67 forks source link

dpi is not a valid config file setting #328

Closed scholar-mage closed 3 years ago

scholar-mage commented 3 years ago

The default config.yml files have a 'dpi' option listed, but it appears this is ignored. It's also not listed as an option inside the conf.rb defaults (see below). Instead, dpi can be passed to Deck.new().

    DEFAULTS = {
      'antialias'     => 'best',
      'backend'       => 'memory',
      'count_format'  => '%02d',
      'custom_colors' => {},
      'dir'           => '_output',
      'hint'          => :none,
      'img_dir'       => '.',
      'progress_bars' => false,
      'prefix'        => 'card_',
      'ldquote'       => "\u201C", # UTF8 chars
      'rdquote'       => "\u201D",
      'lsquote'       => "\u2018",
      'rsquote'       => "\u2019",
      'em_dash'       => "\u2014",
      'en_dash'       => "\u2013",
      'ellipsis'      => "\u2026",
      'smart_quotes'  => true,
      'text_hint'     => 'off',
      'warn_ellipsize' => true,
      'warn_png_scale' => true,
    }
andymeneely commented 3 years ago

Interesting. I'll take a look!

andymeneely commented 3 years ago

So I ended up keeping the behavior the same, but just removed the default from the config for v0.16. I added a comment pointing people to the right place just in case. See 34ce3e84a32d951b415add7a437268045afe13f3