Variable 'Screen' Dimensions

andymikulski / nES6

NES emulator written in ES6

Other

4 stars 1 forks source link

Variable 'Screen' Dimensions #10

Closed andymikulski closed 7 years ago

andymikulski commented 7 years ago

Currently, dimensions are locked in at 256 x 240 pixels. Attempting to change these constants messes with how the image is rendered to canvas. This indicates that there are some hardcoded magic numbers somewhere in the rendering pipeline.

[ ] Find/remove/fix hardcoded magic numbers
[ ] Expose API to get/set screen/render size

andymikulski commented 7 years ago

Digging into it a little bit[0], turns out the NES's native resolution was 256x240. Therefore, I don't think it's necessary/possible to mess with the resolution. Resizing the actual canvas DOM element should be enough for the end developer - if not, this can be readdressed at a later date.

[0] https://en.wikipedia.org/wiki/Nintendo_Entertainment_System#Technical_specifications