search

andyperlitch / ngx-super-table

A feature-rich table component built with angular.
MIT License
115 stars 27 forks source link

Getting an error when creating a build via "ng build --prod" #39

Closed submetu closed 6 years ago

submetu commented 6 years ago

ERROR: ERROR in node_modules/ngx-super-table/superTableRow.component.d.ts.SuperTableRow.html(1,5): : Property 'state' is private and only accessible within class 'SuperTableRow'. node_modules/ngx-super-table/enumFilter.component.d.ts.EnumFilter.html(5,7): : Expected 0 arguments, but got 1.

Any idea what can be the reason?

cmckni3 commented 6 years ago

Hmm, I see the issues in the code on master. I am going to work on setting up ng-packagr to catch these issues before release.

submetu commented 6 years ago

How long will it going to take? any ideas? We were gonna use this library in production soon.

cmckni3 commented 6 years ago

What does your tsconfig.json file look like? It should already work as long as noImplicitAny is set to false.

Also, which version are you using?

cmckni3 commented 6 years ago

Also, the first issue was fixed on August 2nd, 2017 but never published to npmjs.org. I don't have access to the package on npmjs.org.

@andyperlitch

cmckni3 commented 6 years ago

Sending a PR with ng-packagr soon @andyperlitch and @submetu

submetu commented 6 years ago

Any updates?

cmckni3 commented 6 years ago

I merged in the PR but still don't have access to npmjs.org. It should build without AOT.