search

andytill / erlyberly

erlang tracing for the masses
https://twitter.com/erlyberlytips
GNU General Public License v3.0
693 stars 43 forks source link

common-java:DuplicatedBlocks - Source files should not have any duplicated blocks #115

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule common-java:DuplicatedBlocks - Source files should not have any duplicated blocks. This pull request removes 40 minutes of technical debt. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/common-java:DuplicatedBlocks Please let me know if you have any questions. George Kankava

andytill commented 8 years ago

Hi @georgekankava this introduces a bug, have a look at the return string of emptyTupleString in the two formatter classes. It is very useful to see the strings constants in the same file so these do not need to be abstracted.

I could write up an issue with some known code issues for some targeted improvements?

georgekankava commented 8 years ago

@andytill Yes that's correct. Sorry I didn't catch that.