In retrodesign, it's possible to get incorrect results when passing a vector input.
This isn't an issue in the paper reproduction materials (Andrew understood this limitation of the function as written, and all reproduction code works), but it's worth closing off the possibility of this error for more general use in the package, since many R users will think of a vector input before iterating with scalar inputs or passing a list.
This applies to retrodesign, but also the closed form implementation.
Finishing this issue should involve re-writing all functions to handle vectors inputs, and adding test coverage.
Another one from @martijnweterings here;
In
retrodesign, it's possible to get incorrect results when passing a vector input.This isn't an issue in the paper reproduction materials (Andrew understood this limitation of the function as written, and all reproduction code works), but it's worth closing off the possibility of this error for more general use in the package, since many R users will think of a vector input before iterating with scalar inputs or passing a list.
This applies to
retrodesign, but also the closed form implementation.Finishing this issue should involve re-writing all functions to handle vectors inputs, and adding test coverage.
Reprex of this breaking: