search

andytinycat / puppet-omnibus

Omnibus package of Puppet with an embedded Ruby and required gems (Chef-style)
55 stars 34 forks source link

Added support for Fedora, as well as preliminary support for RHEL dependencies. Retracked to Puppet 3.2.2 #8

Closed randomvariable closed 11 years ago

randomvariable commented 11 years ago

Using the facts helper in FPM, assume all RPM targets are Red Hat derivatives and use appropriate dependencies. This has been tested on Fedora, but special cases have been made where RHEL and CentOS differ, though this hasn't been tested yet.

beddari commented 11 years ago

Thanks for your work!

I did something similar back at https://github.com/beddari/puppet-omnibus/commit/3446d39bce0beccc28b1bf7614a14d0a537d84e9 but I didn't complete it, got caught up in other stuff.

I think this style https://github.com/bernd/fpm-recipes/blob/master/freemind/recipe.rb#L12-L18 is the best way of doing cases per os platform as it is hiding most of the implementation. The rpm/deb target case you do I think should be just simplified using the same platform construct.

We also need to (re)verify all the versioning against what Puppetlabs are packaging/using currently. I think at least the hiera and json gems are not in line.

From a quick glance I couldn't tell if there's actually something that diffs between RHEL/Centos and Fedora?

randomvariable commented 11 years ago

Ooh, that is a nicer way of doing the platform cases. I'll try and sort it out tonight. The only difference between RHEL and Fedora that I've found so far is that Fedora 18 has split up the openssl package into openssl (for the command line utilities) and openssl-libs.

andytinycat commented 11 years ago

Yeah, sorry for not commenting on this (thanks @beddari), but I do prefer the other style. If you re-do the PR in that style, I'll pull it.

We can work out where we are with the dependencies at some point. I don't see it being a big deal right now as the dependencies seem to work totally fine for me in prod.

@beddari: I'm going to add you as a contributor; I know you have a lot of ideas about what you want to do with the project, and I don't have the time to work on it at the moment due to other commitments.

beddari commented 11 years ago

I'm closing this as I'm about to rework my own branch. I'll try and keep in mind that Fedora 18 special case, thanks.