Added segmented path - Githubissues

andyw8 / capybara-page-object

MIT License

32 stars 9 forks source link

Open ddidier opened 11 years ago

abotalov commented 11 years ago

I think it doesn't make any sense to use magic comment in every .rb file if it's not needed.

abotalov commented 11 years ago

This pull request includes changes that were already declined in previous pull requests. You shouldn't include them again

ddidier commented 11 years ago

I'm sorry but:

at the time of writing that wasn't declined yet
I don't know how to make a pull request which depends on another one without including it (I searched the internet but only found that is was not possible...) ; but if you have a solution, I'll be glad to do it

andyw8 commented 11 years ago

You should aim to to keep pull requests independent of each other so that the maintainer can choose which to merge, and the order in which to do so.

I suspect you might have branched form another of your branches rather than from master?