andywer / laravel-js-localization

Simple, ease-to-use and flexible package for the Laravel web framework. Allows you to use localized messages of the Laravel webapp (see `resources/lang` directory) in your Javascript code.
MIT License
143 stars 51 forks source link

Disable backwards compatibility in the config #28

Closed tcsehv closed 7 years ago

tcsehv commented 8 years ago

The backwards compatibility check only allows for languages, not for locales. They have to be 2 characters ('[a-z]{2}'), so locales like nl_NL and es-mx are causing issues. This fix allows you to disable the backwards compatibility fix.

It solves #20

andywer commented 8 years ago

@tcsehv Thanks for opening the PR!

Could you please set the ensure_backwards_compatibility config for the JsLocalizationControllerTest::testBackwardsCompatibility test? (https://travis-ci.org/andywer/laravel-js-localization/jobs/168536745#L349)

andywer commented 7 years ago

Ping.

andywer commented 7 years ago

Closing that for now.