search

andywer / leakage

🐛 Memory leak testing for node.
1.58k stars 52 forks source link

Add prepublish script to build files #14

Closed btmills closed 7 years ago

btmills commented 7 years ago

After #12 introduced a build step, it became possible that publishing from a clean repository without first running tests or explicitly building could result in an empty package on npm. This commit adds a prepublish script to build files before publishing.

andywer commented 7 years ago

Thanks, @btmills! But I think it's better to run npm test on prepbulish, so you cannot publish if the test fails.

I had actually already done this, but didn't push it yet. It's now pushed and a PR is open (#15).

Closing this for now. But feel free to comment on the other PR if you feel differently :)