search

andywer / leakage

🐛 Memory leak testing for node.
1.58k stars 52 forks source link

Node 10 Support #27

Closed alvis closed 6 years ago

alvis commented 6 years ago

The original memwatch-next is out of date and fails to be installed under node 10. This PR addresses this issue by swapping a drop-in replacement @airbnb/node-memwatch, which is constantly maintained by the folks at AirBnb.

Note: With this PR, we have to drop support for Node 6 as the new node-memwatch doesn't support it. We should leave 0.3.0 for Node 6, and bump to 0.4.0 for Node 7+.

@andywer: would you mind clearing the cache for the test under Node 8 and retrigger the test. There was a problem with npm I suppose?

andywer commented 6 years ago

Great job, @alvis! Thanks a lot for your contribution :)

Yeah, maybe we make it even v1.0. The only reason I didn't bump to 1.0 yet is because I wanted to give it some time to be battle-tested in the wild. I think we are past that stage now.

philkunz commented 6 years ago

nice :) That one was the only show stopper to adopting nodejs v10.

alvis commented 6 years ago

Nope. I think it's good to go. 😃

andywer commented 6 years ago

Published as v0.4.0