search

andywer / leakage

🐛 Memory leak testing for node.
1.58k stars 52 forks source link

Node version support #3

Closed btmills closed 7 years ago

btmills commented 7 years ago

Again, thank you for building this! It's much easier than trying to implement a leak test for one of my modules on my own.

What versions of Node.js do you intend to support? I'm testing on versions 4 and up, but destructuring is only supporting starting in v6, so prior versions currently encounter a syntax error at iterations.js line 2. Would you be willing to accept a PR that makes this work on v4?

andywer commented 7 years ago

I tested it with node 6. But yeah, node 4+ should be the way to go :)

Would be covered by the follow-up PR to #1 I mentioned there in the review.