andywer / leakage

๐Ÿ› Memory leak testing for node.
1.58k stars 52 forks source link

Switch to @aidemaster/node-memwatch #36

Closed brandonros closed 5 years ago

brandonros commented 5 years ago

This compiles for node.js v10

andywer commented 5 years ago

Brandon, you are a life saver! Thank you so much! ๐Ÿ˜Š

I mean f***ing memwstch still doesnโ€™t compile on node 12 which goes into LTS in a month or so, but this is much better already!

Will merge and release straight away when I get up in the morning. Great job finding that fork! ๐Ÿ™Œ

brandonros commented 5 years ago

Thank you for all of your efforts!

I think performance is still f00ked but I will double check.

brandonros commented 5 years ago

@andywer Yo, check this out.

https://nodejs.org/api/v8.html#v8_v8_getheapsnapshot

maybe you don't need the native module from memwatch?