search

andywer / leakage

🐛 Memory leak testing for node.
1.58k stars 52 forks source link

Testing / CI #4

Closed andywer closed 7 years ago

andywer commented 7 years ago

There must be at least some integration test showing that the whole thing works and works for different node versions.

Correlates with #3 and will be successor of a proposed change in #1.

btmills commented 7 years ago

Since I've already attempted setting this up in Travis, I'll share what I found to give you a head start:

Compiling nan, a transitive dependency via memwatch-next in a Travis container requires a newer compiler than what the environment supplies by default. https://github.com/btmills/queue/pull/7/commits/0fddbf9f2f3c848c8c904f722f5a2992b0983754 configures Travis to install and use g++-4.8, which allows leakage to be installed. With that change, that PR is now passing in Node v6 and v7, and the failures in v4 and v5 are unrelated and will be fixed once #3 is closed.

Once this repository is set up and working in Travis, it would be helpful to document Travis setup instructions (whether the config I linked above or something better) in the readme. I was going to send a PR for that once I had a fully working setup (so pending #3), but since you're looking at setting up Travis for this repository, I left a note here in the meantime!

andywer commented 7 years ago

That really is a head start 😉 Thanks a lot!

But do you think people using the lib care about the travis config? Don't know if documenting it in the README really serves a purpose.

btmills commented 7 years ago

Anyone using leakage who wants to run a leak test in Travis will need to make those changes to .travis.yml. Without them, leakage -> memwatch-next -> nan will fail to install, causing the whole build to go :boom:

Edit: So it's not just this repository that needs the modified config - it's any repository that wants to use leakage as part of the Travis tests.

andywer commented 7 years ago

Of course! 🙈

I am working on #4 right now and will document it properly. I would appreciate you reviewing my PR once it is done :)

mastilver commented 7 years ago

Didn't realize (Didn't really check to be honest :$) you were a already working on that I've submitted a PR #5 , feel free to close it if you already have something working