search

andywer / postcss-debug

Debug your postcss workflow with ease! Creates snapshots of your CSS files before/after each postcss plugin is run.
MIT License
95 stars 7 forks source link

updated UI #10

Closed Gaserd closed 8 years ago

Gaserd commented 8 years ago
andywer commented 8 years ago

Cool! ๐Ÿ‘๐Ÿ‘

I will test it later when I have got some time. Thanks for your work!

Gaserd commented 8 years ago

@andywer Okey, i will wait your test ๐Ÿ‘

Gaserd commented 8 years ago

@andywer I set small fix and add event for change theme, and we have dark theme too ๐Ÿ‘ Change theme : shift + d

andywer commented 8 years ago

Ok, but dark theme should be the default. Got 62% in the poll :)

Btw: We could add a simple theme switch to the footer.

Gaserd commented 8 years ago

I think we need start red theme UI, because Russian Community choosed Dark theme 40% :( And We need real testing for our UI for choose UI

andywer commented 8 years ago

:-/

We should have done only one poll ๐Ÿ˜…. Yeah, but red as default and a switch is fine, too.

Gaserd commented 8 years ago

@andywer Good ๐Ÿ‘ Thanks!

andywer commented 8 years ago

Looks pretty cool! But I've got some minor questions:

  1. Do we need both the "documentation" and "github" link?
  2. Wouldn't a small text link be more convenient to switch the theme? (Like "Switch to dark theme" which turns into "Switch to red theme" after switching)

Suggestion: How about saving the chosen theme in the browser's local storage? It will then remember your favorite theme when you re-open the debugger later.

Gaserd commented 8 years ago

Yeap, we need use localStorage ๐Ÿ‘

  1. Yes, because github link leads code and documentation link leads wiki for our plugin, documentation link need for the future, you can hide it.
  2. No, we talk our users and we provide them small hint
andywer commented 8 years ago

Quick update: I am short of time today, but I managed to clean up the keyboard listener code, integrate it into the app bundle and save the selected theme to the browser's local storage.

Your PR has already bin merged into the develop branch, but my newest changes are not yet pushed.

Gaserd commented 8 years ago

@andywer Okay, it is right!

Gaserd commented 8 years ago
Gaserd commented 8 years ago
andywer commented 8 years ago

@Gaserd Say... Where did the links to the plugin documentations go?

andywer commented 8 years ago

@Gaserd Ahhh... I found it. But it's not dynamic and not clickable anymore... ๐Ÿ™ˆ

andywer commented 8 years ago

On my local develop branch I merged the changes and made static stuff work, but it will take some time to clean up the CSS sheets. They keep growing wild.

I guess I will shift to a webpack / css modules setup to get rather maintainable stylesheets.

One more thing I noticed: I made the plugin help link dynamic again, but it's very likely that you accidentally open the plugin help when you just want to open the snapshot contents or vice versa. Maybe we can find a solution for this :)

Gaserd commented 8 years ago

@andywer hey, you don't worry about the documentation and i dะพnt have nothing against webpack and i can wait so more