search

andywer / threads-plugin

📦 Makes your threads.js code build with webpack out of the box.
Apache License 2.0
28 stars 6 forks source link

fix: inline helper methods that no longer exist in webpack 5 #28

Closed andreialecu closed 3 years ago

andreialecu commented 3 years ago

Fixes #27

PS: I'm not sure why the unit tests don't work locally. I'm getting failures with the master branch without any changes.

andreialecu commented 3 years ago

FWIW: It seems that it no longer fails to require on webpack 5, so the initial crash is gone, but I haven't yet verified functionality.

andreialecu commented 3 years ago

Reference: https://github.com/webpack/webpack/blob/c572c15a413ef7d086b52ccc78d9512a192954d7/lib/ParserHelpers.js#L14-L45

andreialecu commented 3 years ago

I believe this was fixed in #33. Closing