search

andywer / typed-emitter

🔩 Type-safe event emitter interface for TypeScript
MIT License
268 stars 24 forks source link

Point "main" field to index.d.ts #12

Closed thatmarvin closed 3 years ago

thatmarvin commented 3 years ago
Screen Shot 2020-09-22 at 4 35 35 PM

When enforcing the no-unresolved rule with https://www.npmjs.com/package/eslint-plugin-import, eslint will flag this because main in package.json defaults to index.js, which doesn't exist in this repo. So I'm just explicitly defining it here to to fix it.

I understand that this is a rather specific issue with using this eslint-plugin-import, but if you can't think of any downsides, it'd be great to get this in!

andywer commented 3 years ago

Thanks for contributing this small fix, @thatmarvin!

thatmarvin commented 3 years ago

Thank you for a very helpful package @andywer!

andywer commented 3 years ago

@thatmarvin One last question: Did you check that this fix indeed solves your eslint issue (did you monkeypatch your local typed-emitter)? 😅

thatmarvin commented 3 years ago

@andywer Yes I did test by monkeypatching locally!

andywer commented 3 years ago

Published as v1.3.1 🚀