search

andywer / webpack-blocks

📦 Configure webpack using functional feature blocks.
MIT License
2.97k stars 94 forks source link

Remove stale package-lock.json files #270

Closed farism closed 6 years ago

farism commented 6 years ago

Now that webpack-blocks is using yarn workspaces we should remove any package-lock.json files that are generated by NPM. NPM technically is no longer supported by webpack-blocks.

zcei commented 6 years ago

@vlad-zhukov I thought the same, but no - #268 only removed huge parts of the package-lock, but not the file completely. That was a bit missleading from GitHub's collapsed view.

vlad-zhukov commented 6 years ago

I bet these are your local files. You can go through the release-2.0 branch on GitHub to make sure there are no package-lock.jsons left!

Git doesn't remove gitignored files when you checkout.

andywer commented 6 years ago

@vlad-zhukov Good point! But how was @farism able to create a PR against release-2.0, deleting the lock files, if they are already removed? 🤔

zcei commented 6 years ago

And to my comment from above: when you click on "View" in the files section of a PR for a deleted file, it actually shows the state before it has been removed.. doh!

vlad-zhukov commented 6 years ago

I've just made a clean git pull and the only package-lock.json left is in the eslint package. Interestingly both this PR and #268 missed it.

vlad-zhukov commented 6 years ago

Actually I was looking at a different branch, there are not package-lock.json files left in the release-2.0 branch. 😅