andywer / webpack-blocks

📦 Configure webpack using functional feature blocks.
MIT License
2.97k stars 94 forks source link

Change default devtool to cheap-module-eval-source-map #282

Closed pravdomil closed 6 years ago

pravdomil commented 6 years ago

Because they provide same level of detail as cheap-module-source-map but they are faster in rebuild.

see https://webpack.js.org/configuration/devtool

vlad-zhukov commented 6 years ago

Nice catch, thanks! Could you please point it to the release-2.0 branch instead of the master? (See #264 for reference.) And after that you'd also need to make sure tests pass.

pravdomil commented 6 years ago

a need to update snapshot in packages/sample-app/__tests__/__snapshots__/webpack-config.test.js.snap I don't want to setup dev environment I'm editing it from github.com

dmitmel commented 6 years ago

@pravdomil I have a local copy of webpack-blocks so I can make a PR towards your fork with the required changes to snapshots.

pravdomil commented 6 years ago

@dmitmel great

pravdomil commented 6 years ago

All checks have passed

pravdomil commented 6 years ago

I have deleted the original repo so I have to open new PR https://github.com/andywer/webpack-blocks/pull/285