andywer / webpack-blocks

📦 Configure webpack using functional feature blocks.
MIT License
2.97k stars 94 forks source link

Bugfix: Drop awesome-typescript-loader PathPlugin #289

Closed andywer closed 6 years ago

andywer commented 6 years ago

... that "is available only for webpack@2.1". (See their readme)

Couldn't get the end-to-end tests to run successfully on my local machine. It would always fail when using the TsConfigPathsPlugin and would work whenever I remove it.

Not sure if this will have a major impact on the users.

Update: It should be fine, I think, since you are now able to pass the path options directly to the loader. The typescript() block even does that already.

andywer commented 6 years ago

@jvanbruegge Any thoughts on this?

dmitmel commented 6 years ago

@andywer Could you please provide "Steps to reproduce", so that others can test if they can get the same results on their machines?

andywer commented 6 years ago

Damn it. Doesn't happen when doing it in a freshly cloned repo...

It was straight forward:

$ yarn
$ yarn test

And then when running the tests, the typescript end-to-end test hang and just wouldn't finish ever.

When I ran it in a freshly cloned repo, it worked 🙃

Sorry for bothering, guys. Still seems a bit strange, but since it works with a clean repo, I will just close it for now. Might be some stale untracked files, like in the former case. Will clean up my local installation...

andywer commented 6 years ago

Another update: Works for a freshly cloned repo cloned to /tmp/webpack-blocks, but fails when cloning to ~/workspace/webpack-blocks 🤯

$ cd /tmp
$ git clone git@github.com:andywer/webpack-blocks.git -b release-2.0
$ cd webpack-blocks
$ yarn
$ yarn test
$ # works
$ cd ~/workspace
$ rm -rf webpack-blocks
$ git clone git@github.com:andywer/webpack-blocks.git -b release-2.0
$ cd webpack-blocks
$ yarn
$ yarn test
$ # hangs after 66 tests, fan spins up
vlad-zhukov commented 6 years ago

Weird, I am not able to reproduce.