search

andywer / webpack-blocks

📦 Configure webpack using functional feature blocks.
MIT License
2.97k stars 94 forks source link

Upgrade all deps #300

Closed vlad-zhukov closed 6 years ago

vlad-zhukov commented 6 years ago

Ava fails with a weird babel error: Error: You gave us a visitor for the node type TSUnknownKeyword but it's not a valid type

I can also reproduce it locally on release-2.0 branch, but CI doesn't...

vlad-zhukov commented 6 years ago

I guess the ava upgrade from my last PR didn't go well, downgrading the version works however.

andywer commented 6 years ago

PS: Downgrading AVA seems fine.

vlad-zhukov commented 6 years ago

To sum up: if you update from one of previous commits to abb2d05 Upgrade root deps (#299) and run yarn, the yarn ava will run just fine. But on a fresh node_modules install this command will fail due to a weird error in one of Babel plugins ava uses.

I've downgraded ava from 1.0.0-beta.8 to 1.0.0-beta.7, updated almost all other deps and made sure the fresh install passes all tests. Everything should be fine now! 🙏

andywer commented 6 years ago

Sounds good! Build is failing, though 🙃

We either need to find that dependency that's not compatible to node 6 or bump to minimum node 8. I would prefer continued support for node 6 if it's not too much effort.

vlad-zhukov commented 6 years ago

Damn, jsdom v12 dropped support for node 6, downgraded it back to v11.

vlad-zhukov commented 6 years ago

@andywer yeah, we should stick to what node version webpack supports, it's currently >=6.11.5