andywuest / harbour-watchlist

A stock watchlist for SailfishOS
10 stars 7 forks source link

Wrong currency #19

Open dikonov opened 4 years ago

dikonov commented 4 years ago

Sometimes Watchlist shows false information. I noticed that

YANDEX N.V.COM USD0.01 CLA at NASDAQ Basic is displayed as nominated in roubles, but the price figures are in US dollars. The result is ridiculously wrong quotes.

If the source provides wrong currency code, the user should be able to correct it. Or, perhaps, the API field with the true currency code is different from what is used to form the stock details page.

andywuest commented 4 years ago

The general problem is that the original datasource already provides the wrong currency - see

https://www.euroinvestor.dk/markeder/aktier/yandex-nv-com-usd001-cl-a/30350

andywuest commented 4 years ago

The rest endpoint also seems to provide the wrong currency:

https://api.euroinvestor.dk/instruments?ids=30350

dikonov commented 4 years ago

So, there are two fields of information that a user might want to edit: 1) Name of the stock (The names of the Russian comanies provided by the app are strange latinizations and I would prefer to see "ПАО Сбербанк (SBERP)" instead of "Sberbank PJSC") 2) Currency code in case it is wrong.

I would ike to request a new feature - An edit menu action to all the stocks allowing the user to change the stock name and currency code. The edited strings should be displayed in the list instead of the original ones similar to localization.

andywuest commented 4 years ago

Not sure about this one - i think i will start with adding the moex backend - then you should get the cyryllic characters out of the box and also with the right quotes. for the backend i have everything i need and it should be not too difficult to add.