PA Review: User Authentication

[andywynkoop]

• [x] Backend: DB, model, controller, views
• [x] Redux Loop: ajax, actions, reducer
• [x] Presentational Components and Containers
• [x] Styling
• [x] Smooth, bug-free navigation
• [x] Adequate and appropriate seeds

[andywynkoop]

Since last meeting: Change user model to take birthday, sex Handle errors in form validation Validate form before making a request Make a responsive error modal to display informative error messages for sign up form and session navbar Display first name instead of email on sign in Add demo user button to navbar

[andywynkoop]

Should component hierarchy reflect what the actual components are or should it just be a general overview?

[niartenyaw]

Looks awesome!

Functionality

• [x] I think there should be a better error than User url has already been taken. The user won't know that their first and last name is the problem. Might even want to not fail the validation. just add numbers to the end if users have the same name. Don't want to block people with the same name.
• [x] Errors for sign in should be closer to that form, not in the sign up form.
• [x] Going to http://thoughtspot.herokuapp.com/#/eribuvgireutbgiertubg should either redirect me to a relevant page or show an error page

Styling

• [x] Highlighting over Why do I need to provide my birthday? should probably give me the pointer cursor because it's acting like a link.
• [x] Same thing, pointer cursor, with the want to try this site
• [x] I can scroll a bit up and down on the sign up page. It should not be scrollable

[niartenyaw]

And for the component hierarchy, I wouldn't worry too much about updating it. If you want to, feel free but you're not required to