demo.py is throwing an error after initial pull

andyzeng / tsdf-fusion-python

Python code to fuse multiple RGB-D images into a TSDF voxel volume.

http://andyzeng.github.io/

BSD 2-Clause "Simplified" License

1.25k stars 219 forks source link

demo.py is throwing an error after initial pull #17

Closed Codeguyross closed 4 years ago

Codeguyross commented 4 years ago

python demo.py Traceback (most recent call last): File "demo.py", line 9, in

    import fusion
  File "tsdf-fusion-python/fusion.py", line 346
    xyz_t_h = (transform @ xyz_h.T).T
                         ^
SyntaxError: invalid syntax

kevinzakka commented 4 years ago

Hi @Codeguyross,

The @ operator is equivalent to np.dot in python3. It would seem you are using python2?

I'll change it back to np.dot and submit a PR so as to not break backwards compatibility with python2.

Cheers

Codeguyross commented 4 years ago

I tried python2.7 as it was listed on the getting started. It did work when I made a python3 environment and since python2.7 is no longer supported, its probably fine to leave it be.

Also thanks for the speedy response and your work!

kevinzakka commented 4 years ago

Totally my fault for breaking the compatibility :) I totally support the move to python3 btw.

Also thanks for the speedy response and your work!

All credit goes to @andyzeng , I'm just an appreciative contributor :)