andyzhou192 / winezeug

Automatically exported from code.google.com/p/winezeug
0 stars 0 forks source link

Avoid re-checksumming already-downloaded files #173

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Large files take a long time to checksum.

Checksumming is very much worth it when first downloading, but much
less worth it later.  The download function should probably avoid
re-checksumming already downloaded files.

Original issue reported on code.google.com by daniel.r...@gmail.com on 19 Sep 2010 at 3:34

GoogleCodeExporter commented 9 years ago
Hmm, I respectfully disagree. If a download is canceled midway, then the same 
verb is rerun, you'd probably have problems.

Original comment by austinenglish@gmail.com on 20 Sep 2010 at 8:23

GoogleCodeExporter commented 9 years ago
I agree, we need to handle the interrupted download case.

I tested that case, and I think the download is removed.  Not sure if it
handles abrupt shutdown though.

Original comment by daniel.r...@gmail.com on 20 Sep 2010 at 1:40

GoogleCodeExporter commented 9 years ago
wisotool avoids the extra checksum as of r1599,
http://code.google.com/p/winezeug/source/detail?r=1599&path=/trunk/wisotool
it snuck in with batman, oops.

Original comment by daniel.r...@gmail.com on 25 Sep 2010 at 8:15

GoogleCodeExporter commented 9 years ago

Original comment by daniel.r...@gmail.com on 11 Oct 2010 at 9:55