search

aneesh-neelam / VITacademics

The VITacademics API Server
https://vitacademics-rel.herokuapp.com
GNU General Public License v3.0
20 stars 22 forks source link

Changes to Grades Response Format #93

Closed biocross closed 9 years ago

biocross commented 9 years ago

The whole point of building the grades features was to display a table in which people could dynamically change grades, and display the resulting CGPA.

Hence,

Also, I think the GPA, and CGPA calculation should be left to the client apps.

aneesh-neelam commented 9 years ago

@VinayGupta23: Your thoughts?

kishore-narendran commented 9 years ago

Why don't you filter it out as needed on the client end?

biocross commented 9 years ago

Because it'll be a lot of work on the iOS framework I'm using, and also, why do it 3 times on 3 platforms, when it can be done once?

aneesh-neelam commented 9 years ago

@kishore-narendran: Because he's very lazy. His actual reasoning was moment.js is easier to use than any DateTime iOS library.

biocross commented 9 years ago

That too :P

kishore-narendran commented 9 years ago

I thought it was all supposed to be complete. Okay but this shouldn't be a big change.

aneesh-neelam commented 9 years ago

It is supposed to be complete and it is complete.

VinayGupta23 commented 9 years ago

No. Its perfect as it is. I've done a lot of research on the grades that are being sent for various students of all performances.

GPA and CGPA change for a semester as per clearance of arrears and re-term-ends. If we get the subjects alone, the calculated grade semester wise may be incorrect.

Also, getting every single detail (like withdrawal and arrear, N etc) is a way for a user to know exactly what he did and how he went about the entire degree. It gives completeness. I believe let the JSON be as is.

Sent from my Windows Phone

From: Kishore Narendranmailto:notifications@github.com Sent: ‎16-‎06-‎2015 22:28 To: aneesh-neelam/VITacademicsmailto:VITacademics@noreply.github.com Cc: Vinay Guptamailto:vinay.23.gupta@outlook.com Subject: Re: [VITacademics] Changes to Grades Response Format (#93)

Why don't you filter it out as needed on the client end?

Reply to this email directly or view it on GitHub: https://github.com/aneesh-neelam/VITacademics/issues/93#issuecomment-112496992

aneesh-neelam commented 9 years ago

@biocross: You're outvoted. Get cracking on Objective-C.

VinayGupta23 commented 9 years ago

Making a calculator feature is a client-end implementation.

@aneesh-neelam :P

biocross commented 9 years ago

:(

aneesh-neelam commented 9 years ago

@biocross: Consistency man. Keep calm and code.

biocross commented 9 years ago

alrighty then.