aneeshnaik / lintsampler

Efficient random sampling via linear interpolation.
https://lintsampler.readthedocs.io
MIT License
1 stars 1 forks source link

JOSS Minor Changes #11

Closed aneeshnaik closed 1 day ago

aneeshnaik commented 1 week ago

The aim of this PR is to address the 'minor' changes that the reviewers have suggested in the JOSS review process. The more substantial queries will be addressed separately.

Suggestions from @vankesteren:

Suggestions from @matt-graham (these collectively resolve #10)

michael-petersen commented 1 week ago

Part of what 'PDF function' was meant to describe was the user providing a function (in the Python sense) that computes the PDF itself. So I'm thinking it makes sense to say 'function describing the PDF', e.g. 'the user provides a Python function defining the target PDF'. Is 'Python function' over definition, or helpful to clarify the multiple uses of function?

I've followed this strategy already; but we can change if desired (hence the box left un-ticked).

michael-petersen commented 3 days ago

I've drafted the example; it might benefit from a bit of wordsmithing. After that, I think the checklist is done!