search

anegostudios / VintageStory-Issues

Vintage Story's public issue tracker for reporting bugs, crashes and the like
45 stars 16 forks source link

Possible error in RenderPlants.StartRenderingFrames #2332

Closed xxmicloxx closed 1 year ago

xxmicloxx commented 1 year ago

Game Version

v1.17.9

Platform

Windows

Modded

Vanilla

SP/MP

None

Description

There seems to be a mistake in the matrix multiplication for calculating the MVP matrix in RenderPlants.StartRenderingFrames(). When the MVP matrix rows are gathered into the variables p2, p3, p4 and p5, actually, the last row is not fetched, instead, the second to last row is used twice, resulting, at least theoretically, in invalid matrix multiplication (see screenshot). I am not sure if this affects this use case at all but it does look like it might be a mistake that should be fixed.

How to reproduce

No response

Screenshots

image

Logs

No response

tyronx commented 1 year ago

Thanks for the report, this will be fixed in 1.17.10.

Just for info: The entire instanced plant rendering system will be removed again in 1.18