anegostudios / VintageStory-Issues

Vintage Story's public issue tracker for reporting bugs, crashes and the like
46 stars 16 forks source link

Axing the wood in crafting table leads to crash #2427

Closed ivanpopelyshev closed 1 month ago

ivanpopelyshev commented 1 year ago

Game Version

v1.18-pre3

Platform

None

Modded

None

SP/MP

None

Description

Exception on server side. Two times. There was a birch and a pine blocks, both crashed. Inventory was full.

How to reproduce

I dont know yet.

Screenshots

No response

Logs

5.3.2023 09:28:13 [Error] System.NullReferenceException: Object reference not set to an instance of an object
  at Vintagestory.Common.ItemSlotCraftingOutput.triggerEvent (Vintagestory.API.Common.ItemStack craftedStack, System.Int32 mo
ved, Vintagestory.API.Common.IPlayer actingPlayer) [0x0001e] in <9e718ef17ce44709a4eacddd4ec5d7d1>:0
  at Vintagestory.Common.ItemSlotCraftingOutput.TryPutInto (Vintagestory.API.Common.ItemSlot sinkSlot, Vintagestory.API.Commo
n.ItemStackMoveOperation& op) [0x0009b] in <9e718ef17ce44709a4eacddd4ec5d7d1>:0
  at Vintagestory.Server.ServerPlayerInventoryManager.DropItem (Vintagestory.API.Common.ItemSlot slot, System.Boolean fullSta
ck) [0x000c9] in <9e718ef17ce44709a4eacddd4ec5d7d1>:0
  at Vintagestory.Common.InventoryCraftingGrid.ActivateSlot (System.Int32 slotId, Vintagestory.API.Common.ItemSlot sourceSlot
, Vintagestory.API.Common.ItemStackMoveOperation& op) [0x00056] in <9e718ef17ce44709a4eacddd4ec5d7d1>:0
  at Vintagestory.Common.InventoryNetworkUtil.HandleClientPacket (Vintagestory.API.Common.IPlayer byPlayer, System.Int32 pack
etId, Packet_Client packet) [0x000f3] in <9e718ef17ce44709a4eacddd4ec5d7d1>:0
  at Vintagestory.Server.ServerSystemInventory.HandleActivateInventorySlot (Packet_Client packet, Vintagestory.Server.Connect
edClient client) [0x00023] in <9e718ef17ce44709a4eacddd4ec5d7d1>:0
  at Vintagestory.Server.ServerMain.HandleClientPacket (Vintagestory.Server.ConnectedClient client, System.Byte[] data) [0x0005a] in <9e718ef17ce44709a4eacddd4ec5d7d1>:0
  at Vintagestory.Server.ServerMain.ProcessNetMessage (Vintagestory.Common.NetIncomingMessage msg, Vintagestory.Common.NetServer mainSocket) [0x00151] in <9e718ef17ce44709a4eacddd4ec5d7d1>:0
Craluminum2413 commented 1 year ago

Are you on windows? Do you mean crafting grid?

ivanpopelyshev commented 1 year ago

image

Just now, there was 16 wood in crafting, I pushes LBM with shift on the wood bar, got crash. And there's wood in my main inventory, not full

ivanpopelyshev commented 1 year ago

Bigger picture:

image

I pressed the button and it crashed again. Yep, that action crashed it again.

Here's what I see after I reconnect:

image

ivanpopelyshev commented 1 year ago

Linux server, windows client.

Nyuhnyash commented 1 year ago

Any crafting attempt (while Shift pressed) with full inventory causes an unhandled NRE => Client disconnecting.

2023-03-05_19-52-47

Craluminum2413 commented 1 year ago

I can't reproduce it in 1.18.0-pre.3 on windows

ivanpopelyshev commented 1 year ago

What if it exists if i already have wood bars in ventory, but all filled ?

Here's dotnet version:

 *** 6.12.0.182-0xamarin1+ubuntu2004b1 500
        500 https://download.mono-project.com/repo/ubuntu stable-focal/main amd6 
Craluminum2413 commented 1 year ago

@Nyuhnyash Are you on Linux too?

Nyuhnyash commented 1 year ago

@Craluminum2413 Windows server + client

Craluminum2413 commented 1 month ago

Closing due to inactivity