anegostudios / VintageStory-Issues

Vintage Story's public issue tracker for reporting bugs, crashes and the like
47 stars 16 forks source link

Book crash on version 1.18.3 stable #2740

Closed NinaraMamiko closed 9 months ago

NinaraMamiko commented 1 year ago

Game Version

v1.18.3 (Stable)

Platform

Windows

Modded

Modded

SP/MP

Singleplayer

Description

While sitting and writing in a book the game crashed halfway through the second page.

The only mod is healing while sleeping.

How to reproduce

The book used plain leather to make and I was sitting while I wrote in it.

Screenshots

No response

Logs

Running on 64 bit Windows with 16 GB RAM Game Version: v1.18.3 (Stable) 5/13/2023 12:28:34 AM: Critical error occurred Loaded Mods: healingwhilesleepingfix@1.0.1, game@1.18.3, creative@1.18.3, survival@1.18.3 System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource) at Vintagestory.GameContent.GuiDialogEditableBook.onTryTextChange(List1 lines) in VSSurvivalMod\Systems\WritingSystem\GuiDialogEditableBook.cs:line 78 at Vintagestory.API.Client.GuiElementEditableTextBase.LoadValue(List1 newLines) in VintagestoryApi\Client\UI\Elements\Impl\Interactive\Text\GuiElementEditableTextBase.cs:line 281 at Vintagestory.API.Client.GuiElementEditableTextBase.SetValue(String text, Boolean setCaretPosToEnd) in VintagestoryApi\Client\UI\Elements\Impl\Interactive\Text\GuiElementEditableTextBase.cs:line 266 at Vintagestory.GameContent.GuiDialogReadonlyBook.updatePage(Boolean setCaretPosToEnd) in VSSurvivalMod\Systems\WritingSystem\GuiDialogReadonlyBook.cs:line 174 at Vintagestory.GameContent.GuiDialogEditableBook.OnKeyDown(KeyEvent args) in VSSurvivalMod\Systems\WritingSystem\GuiDialogEditableBook.cs:line 239 at Vintagestory.Client.NoObf.GuiManager.OnKeyDown(KeyEvent args) in VintagestoryLib\Client\Systems\Gui\GuiManager.cs:line 361 at Vintagestory.Client.NoObf.ClientMain.OnKeyDown(KeyEvent args) in VintagestoryLib\Client\ClientMain.cs:line 1738 at Vintagestory.Client.NoObf.ClientPlatformWindows.game_KeyDown(Object sender, KeyboardKeyEventArgs e) in VintagestoryLib\Client\ClientPlatform\Input.cs:line 250 at System.EventHandler1.Invoke(Object sender, TEventArgs e) at System.EventHandler1.Invoke(Object sender, TEventArgs e) at OpenTK.Platform.NativeWindowBase.OnKeyDown(Key key, Boolean repeat) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\Platform\NativeWindowBase.cs:line 130 at OpenTK.Platform.Windows.WinGLNative.HandleKeyboard(IntPtr handle, WindowMessage message, IntPtr wParam, IntPtr lParam) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\Platform\Windows\WinGLNative.cs:line 646 at OpenTK.Platform.Windows.WinGLNative.WindowProcedure(IntPtr handle, WindowMessage message, IntPtr wParam, IntPtr lParam) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\Platform\Windows\WinGLNative.cs:line 828 at OpenTK.Platform.Windows.Functions.DispatchMessage(MSG& msg) at OpenTK.Platform.Windows.WinGLNative.ProcessEvents() in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\Platform\Windows\WinGLNative.cs:line 1551 at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\GameWindow.cs:line 369 at Vintagestory.Client.ClientProgram.Start(ClientProgramArgs args, String[] rawArgs) at Vintagestory.ClientNative.CrashReporter.Start(ThreadStart start) in VintagestoryLib\Client\ClientPlatform\ClientNative\CrashReporter.cs:line 93

Event Log entries containing Vintagestory.exe, the latest 3

{ TimeGenerated = 5/1/2023 7:23:35 PM, Site = , Source = Application Hang, Message = The program Vintagestory.exe version 1.18.1.0 stopped interacting with Windows and was closed. To see if more information about the problem is available, check the problem history in the Security and Maintenance control panel. }

{ TimeGenerated = 4/20/2023 9:11:13 PM, Site = , Source = Application Hang, Message = The program Vintagestory.exe version 1.18.0.0 stopped interacting with Windows and was closed. To see if more information about the problem is available, check the problem history in the Security and Maintenance control panel. }

{ TimeGenerated = 4/16/2023 6:59:33 PM, Site = , Source = Windows Error Reporting, Message = Fault bucket 1880964244831943275, type 4 Event Name: APPCRASH Response: Not available Cab Id: 0

Problem signature: P1: Vintagestory.exe P2: 1.17.11.0 P3: 63e108be P4: KERNELBASE.dll P5: 10.0.22621.1555 P6: 235a45d0 P7: c000041d P8: 000000000008fdec P9: P10:

Attached files: \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.1fc99eb8-6ce6-4d5e-96b8-c7919dec579d.tmp.dmp \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.ecbdd04e-4bbe-487c-9c20-c08ce79ab918.tmp.WERInternalMetadata.xml \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.0acf9a58-27ca-430a-a386-31d2aecdc182.tmp.csv \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.c684c895-f52f-433f-8c15-d0e5a0d3ae9e.tmp.txt \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.36c5ce9c-f4c3-4293-8851-44de99c84f3d.tmp.xml

These files may be available here: \?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_Vintagestory.exe_9d8cf8972f1bf50868658e3c26e1f54c027de_1112ccc3_fdfb8edf-4887-4cd1-a30b-f6adee82b4cb

Analysis symbol: Rechecking for solution: 0 Report Id: cad169e5-6806-4f35-9b4b-ba4c0bf1ea32 Report Status: 268435456 Hashed bucket: 4fd7c6586457998c1a1a8703d06b3a6b

radfast commented 1 year ago

The crash report looks strange.

These words are not normal:

1 lines) in VSSurvivalMod\Systems\WritingSystem\GuiDialogEditableBook.cs:line 78 at Vintagestory.API.Client.GuiElementEditableTextBase.LoadValue(List1 newLines

radfast commented 1 year ago

I have not been able to reproduce the problem on testing. There was a previous problem with editing books, trying to move the cursor right at the end of the text caused crashes, but that problem was fixed in 1.18.3.

Can you make this crash happen again, every time? If so please do you mind to describe in more detail the exact steps to make it crash. A screenshot of how the book looks on screen just before the crash could also be great.

NinaraMamiko commented 1 year ago

2023-05-15_13-26-20

Took the picture right before I had the smart idea to arrow to the right so that could have been part of the trigger I never noticed. I had also disabled the only active mod I had just in case. There is also another report from me from version 1.18.2 that got moved to a completed folder in case that code helps. I also held back on putting a title in with all attempts to write.

Running on 64 bit Windows with 16 GB RAM Game Version: v1.18.3 (Stable) 5/15/2023 1:26:25 PM: Critical error occurred Loaded Mods: game@1.18.3, creative@1.18.3, survival@1.18.3 System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: index at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource) at Vintagestory.GameContent.GuiDialogEditableBook.onTryTextChange(List1 lines) in VSSurvivalMod\Systems\WritingSystem\GuiDialogEditableBook.cs:line 78 at Vintagestory.API.Client.GuiElementEditableTextBase.LoadValue(List1 newLines) in VintagestoryApi\Client\UI\Elements\Impl\Interactive\Text\GuiElementEditableTextBase.cs:line 281 at Vintagestory.API.Client.GuiElementEditableTextBase.SetValue(String text, Boolean setCaretPosToEnd) in VintagestoryApi\Client\UI\Elements\Impl\Interactive\Text\GuiElementEditableTextBase.cs:line 266 at Vintagestory.GameContent.GuiDialogReadonlyBook.updatePage(Boolean setCaretPosToEnd) in VSSurvivalMod\Systems\WritingSystem\GuiDialogReadonlyBook.cs:line 174 at Vintagestory.GameContent.GuiDialogEditableBook.OnKeyDown(KeyEvent args) in VSSurvivalMod\Systems\WritingSystem\GuiDialogEditableBook.cs:line 239 at Vintagestory.Client.NoObf.GuiManager.OnKeyDown(KeyEvent args) in VintagestoryLib\Client\Systems\Gui\GuiManager.cs:line 361 at Vintagestory.Client.NoObf.ClientMain.OnKeyDown(KeyEvent args) in VintagestoryLib\Client\ClientMain.cs:line 1738 at Vintagestory.Client.NoObf.ClientPlatformWindows.game_KeyDown(Object sender, KeyboardKeyEventArgs e) in VintagestoryLib\Client\ClientPlatform\Input.cs:line 250 at System.EventHandler1.Invoke(Object sender, TEventArgs e) at System.EventHandler1.Invoke(Object sender, TEventArgs e) at OpenTK.Platform.NativeWindowBase.OnKeyDown(Key key, Boolean repeat) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\Platform\NativeWindowBase.cs:line 130 at OpenTK.Platform.Windows.WinGLNative.HandleKeyboard(IntPtr handle, WindowMessage message, IntPtr wParam, IntPtr lParam) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\Platform\Windows\WinGLNative.cs:line 646 at OpenTK.Platform.Windows.WinGLNative.WindowProcedure(IntPtr handle, WindowMessage message, IntPtr wParam, IntPtr lParam) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\Platform\Windows\WinGLNative.cs:line 828 at OpenTK.Platform.Windows.Functions.DispatchMessage(MSG& msg) at OpenTK.Platform.Windows.WinGLNative.ProcessEvents() in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\Platform\Windows\WinGLNative.cs:line 1551 at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second) in C:\Users\Nexrem\Desktop\transfer\opentk\src\OpenTK\GameWindow.cs:line 369 at Vintagestory.Client.ClientProgram.Start(ClientProgramArgs args, String[] rawArgs) at Vintagestory.ClientNative.CrashReporter.Start(ThreadStart start) in VintagestoryLib\Client\ClientPlatform\ClientNative\CrashReporter.cs:line 93

Event Log entries containing Vintagestory.exe, the latest 3

{ TimeGenerated = 5/1/2023 7:23:35 PM, Site = , Source = Application Hang, Message = The program Vintagestory.exe version 1.18.1.0 stopped interacting with Windows and was closed. To see if more information about the problem is available, check the problem history in the Security and Maintenance control panel. }

{ TimeGenerated = 4/20/2023 9:11:13 PM, Site = , Source = Application Hang, Message = The program Vintagestory.exe version 1.18.0.0 stopped interacting with Windows and was closed. To see if more information about the problem is available, check the problem history in the Security and Maintenance control panel. }

{ TimeGenerated = 4/16/2023 6:59:33 PM, Site = , Source = Windows Error Reporting, Message = Fault bucket 1880964244831943275, type 4 Event Name: APPCRASH Response: Not available Cab Id: 0

Problem signature: P1: Vintagestory.exe P2: 1.17.11.0 P3: 63e108be P4: KERNELBASE.dll P5: 10.0.22621.1555 P6: 235a45d0 P7: c000041d P8: 000000000008fdec P9: P10:

Attached files: \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.1fc99eb8-6ce6-4d5e-96b8-c7919dec579d.tmp.dmp \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.ecbdd04e-4bbe-487c-9c20-c08ce79ab918.tmp.WERInternalMetadata.xml \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.0acf9a58-27ca-430a-a386-31d2aecdc182.tmp.csv \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.c684c895-f52f-433f-8c15-d0e5a0d3ae9e.tmp.txt \?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.36c5ce9c-f4c3-4293-8851-44de99c84f3d.tmp.xml

These files may be available here: \?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_Vintagestory.exe_9d8cf8972f1bf50868658e3c26e1f54c027de_1112ccc3_fdfb8edf-4887-4cd1-a30b-f6adee82b4cb

Analysis symbol: Rechecking for solution: 0 Report Id: cad169e5-6806-4f35-9b4b-ba4c0bf1ea32 Report Status: 268435456 Hashed bucket: 4fd7c6586457998c1a1a8703d06b3a6b Cab Guid: 0 }

NinaraMamiko commented 1 year ago

I sat down in the kitchen. I started writing. I left putting a title in for later. I do have a second pen in a chest in the basement. After some back and forth due to misspelling I took a picture and at the end of my last sentence hit the right arrow about three times and got the crash. I was only on the first page this time.

radfast commented 9 months ago

Fixed in 1.19.4 when it comes, sorry it took us so long it was a difficult one to track down!