search

anegostudios / VintageStory-Issues

Vintage Story's public issue tracker for reporting bugs, crashes and the like
46 stars 16 forks source link

Applying potash to tilled soil upgrades it to the next soil tier #2769

Closed Guimoute closed 1 year ago

Guimoute commented 1 year ago

Game Version

1.18.5

Platform

Windows

Modded

Vanilla

SP/MP

Singleplayer

Description

Hello,

When you apply bonemeal and compost to your soil, it gets a stats boost and speckles of dust on top of it but the underlying soil does not change. However when you apply potash, the soil upgrades after a few seconds. This should not happen. The expected behavior is for this soil block to get only a stats boost, not a soil tier boost.

This also means you can make terra preta at home and removes one reason to go find it in the wild.

How to reproduce

Apply potash to tilled soil.

Screenshots

https://github.com/anegostudios/VintageStory-Issues/assets/51537797/58d1a816-b32a-46e2-b7e0-0f2793871d92

Logs

No response

VallenFrostweaver commented 1 year ago

You are simply making High Fertility soil that will later on have a higher K value of up to 15% more (Medium soil 50% for all values). Terra preta starts at 80% for all values and once Potash is added it can have it's K value increased to 95% permanently. This is not a bug as far as I can tell. At best, the 15% increase on the Potash should read "up to" 15% since when adding it to anything not terra preta will be close to but not 15% bonus K value.

radfast commented 1 year ago

For the reasons mentioned by @VallenFrostweaver, this is intended behaviour. Potash can permanently increase tilled soil by one tier, depending on the soil's previous level. The "High Fertility" farmland seen in your video is not Terra Preta, it is one tier below Terra Preta.

Guimoute commented 1 year ago

@radfast I didn't say the farmland seen in the video was terra preta. You can improve low fertility soil to medium, medium to high, and high to terra preta.

Here, by applying potash to increase the K max nutrients by 15% as the handbook indicates, I'm effectively increasing the N and P max nutrients too via the soil tier upgrade "bug" (in my opinion).

This behavior also lowers immensely the interest of the composting mechanic since the upgrade cost from medium to high fertility goes from 32 food items (= 32 rot = 8 compost = 1 block) to 1 potash item.

A clearer video:

https://github.com/anegostudios/VintageStory-Issues/assets/51537797/1da2475e-c862-400a-b292-fad9e7b42b07

Edit: after testing, it seems that the tier upgrade is only visual. I still find it very confusing. I guess that makes this post go from a bug report to a QoL suggestion: something called "terra preta" in game should have the stats of terra preta. A high fertility soil with an improved K retention should look like a high fertility soil.

VallenFrostweaver commented 1 year ago

It does look like a high fertility as far as I can see. In either of your videos you don't place down Terra preta which is almost black. I can understand the confusion though.

Guimoute commented 1 year ago

@VallenFrostweaver Well yes, that is the problem. I don't place down terra preta yet I get "terra preta" in the infobox at the end of the second video.

I am surprised nobody reported "my terra preta is stuck at 65/65/80% N/P/K despite having been left fallow for years" because of the naming confusion.

Guimoute commented 1 year ago

As a dirty workaround, I'll modify potash.json/"attributes/fertilizerProps/permaboost/k" from 15 to 14.999, since Craluminum told me the block type/texture used by a farmland block is given by comparing its max nutrients to the Fertilities dictionary.

Some people do believe potash is the way to upgrade high fertility soil in terra preta: https://old.reddit.com/r/VintageStory/comments/14o0aqp/how_to_compost/jqa889v/

Guimoute commented 1 year ago

More people thinking potash upgrades soil types: https://www.vintagestory.at/forums/topic/11103-is-there-a-point-to-high-fertility-soil/?do=findComment&comment=48113