anegostudios / VintageStory-Issues

Vintage Story's public issue tracker for reporting bugs, crashes and the like
47 stars 16 forks source link

Can't align plank slabs and blocks in same direction - plank slabs do not offer -ew or -ud variants to match full blocks #3475

Open malnaur opened 10 months ago

malnaur commented 10 months ago

Game Version

1.19.1

Platform

Windows

Modded

Modded

SP/MP

Multiplayer

Description

Plank slabs and plank blocks do not align grain direction when placed and wrench rotations are not flexible enough to correct this. In screen cap below, the seam where blocks transition to slabs is obvious. Blocks align based on player facing when placed. Slabs do not seem to follow this convention.

How to reproduce

No response

Screenshots

2024-01-19_11-44-53

Logs

Log

Medic8dGamer710 commented 10 months ago

I wonder if this is related to crates being uncraftable because of some change they made to planks?

Craluminum2413 commented 10 months ago

@Medic8dGamer710 completely unrelated

radfast commented 10 months ago

The issue is better written like this: plank slabs blocks do not offer east-west rotation of their upper face texture, only north-south.

It's not a placement or a wrench issue: the other-oriented block you want to see here literally does not exist in the game right now.

malnaur commented 10 months ago

The issue is better written like this: plank slabs blocks do not offer east-west rotation of their upper face texture, only north-south.

It's not a placement or a wrench issue: the other-oriented block you want to see here literally does not exist in the game right now.

I would have written it that way if I knew the root cause :) You cheated using your superior knowledge. I assume this problem exists for other wood varieties as well?

radfast commented 10 months ago

Yes. Resolution of this would require a second rotated variants of each slab block, for each wood type, plus code to somehow rotate those (e.g. with wrench). We can look at that as a feature for 1.20, but right now it's how things are.

radfast commented 10 months ago

I'll mark this "won't fix" as it's too late now to include this in 1.19. But I'll leave it open so that it can maybe be added to 1.20.

malnaur commented 10 months ago

The full blocks orient based on character facing direction and adjacent plank blocks. Slab blocks should be no different and not require a new solution. Also, the textures are all there, so why is it SO hard to create more orientation sets?

radfast commented 10 months ago

For sure it requires a new solution, these slab blocks would have different variants compared with, say, stone slabs, so that regular slab code would not "just work" for them. Plus, to make placement "should be no different" requires significant new code, as slab blocks currently use orientation and adjacent blocks to decide which side of slab to place.

For now:

malnaur commented 10 months ago

Well, to be honest, the current slab placement mechanic is non-intuitive and very finicky. I am far more likely to get an orientation I don't want and have to break-and-replace. So, a complete rethink of slabs is something I would appreciate.

pingouyn commented 10 months ago

I conquer somewhat with @malnaur. Although the actual system is far better than other blocky games that won't be mentionned here (Voldemo.... hmm), it can be a bit finicky at times and can often lead to having to remove the slab. Maybe an idea could be to see where the slab will end up so that the slab can be moved before clicking it into place? Either a ghostly image of the slab or another tiny visual aid. Not a full overhaul of the placement system, "just" an additional visual aid (still a lot of coding I am sure but less than changing the system entirely).

Craluminum2413 commented 1 month ago

Wasn't added to 1.20