anegostudios / VintageStory-Issues

Vintage Story's public issue tracker for reporting bugs, crashes and the like
47 stars 16 forks source link

Metal Trapdoors hitbox updates incorrectly and sounds like a wooden door #4102

Open pizza2004 opened 2 months ago

pizza2004 commented 2 months ago

Game Version

v1.20.0 pre-1

Platform

Windows

Modded

None

SP/MP

Singleplayer

Description

When opening and closing the new iron trapdoor it is not properly updating the hitbox to show the new area.

The material is also wood. And they can only be placed in one specific orientation although maybe that is intended.

How to reproduce

Just place down an iron trapdoor in the world and interact with it.

Screenshots

No response

Logs

Log

RedramVS commented 2 months ago

I've updated the material (and also made them craftable). The orientation thing will take someone more skilled that me to resolve.

Craluminum2413 commented 1 month ago

Fixed in pre.4

pizza2004 commented 1 month ago

It is not fixed in pre.4, as the hitbox still does not update correctly.

Craluminum2413 commented 1 month ago

@pizza2004 Can't reproduce

Craluminum2413 commented 1 month ago

Ok reproduced with metal trapdoors

Craluminum2413 commented 1 month ago

@RedramVS Fix is the same as for wooden trapdoor, just make metal trapdoor match wooden trapdoor json. Instead this

"behaviors": [
    { "name": "Lockable" },
    { "name": "Door" },
    { "name": "BlockEntityInteract" }
],
"entityBehaviors": [{ "name": "Door" }],

should be this

"behaviors": [
    { "name": "Lockable" },
    { "name": "TrapDoor" },
    { "name": "BlockEntityInteract" }
],
"entityBehaviors": [{ "name": "TrapDoor" }],

Also there is typo in wooden trapdoor attributes, which makes it not group in handbook fix: ["door-{material}-*"] => ["trapdoor-{style}-*"]

pizza2004 commented 1 month ago

Metal Trapdoors should also probably have the sounds changed to match the iron door.

AreYSerious commented 5 days ago

image Screenshot 2024-11-22 132742

There is no difference between those blocks one is called rusted and the other iron both have same shape and model

also pre.13 has still the issue with the hitbox not being correctly

AreYSerious commented 5 days ago

same goes for the other iron trap doors image

pizza2004 commented 5 days ago

The JSON file also has combustibleProps when it shouldn't, clearly copied from the wood file. Same with the other metal doors (except the iron door) actually.