search

aneilbaboo / replayer

Replay HTTP requests for testing Node.js / Javascript code
Apache License 2.0
33 stars 7 forks source link

Stub all request methods instead of just abort and setTimeout #10

Closed witq closed 7 years ago

witq commented 7 years ago

I've been getting errors about setNoDelay, setSocketKeepAlive and some other http.request methods being undefined when trying to record requests made with the official elasticsearch client. I thought it might be a good idea to stub more of the http.request methods, even the obscure ones.

aneilbaboo commented 7 years ago

@witq Sorry, I don't know why I didn't see this earlier. I'll take a look.

witq commented 7 years ago

No worries, this is really minor and can be ignored.

witq commented 7 years ago

Hi, no worries. I'm pretty sure I ran the tests before submitting this PR, but maybe I forgot to do it. I'll look into it.

wt., 23 maj 2017 o 16:20 użytkownik Aneil Mallavarapu < notifications@github.com> napisał:

Sorry this took so long. I noticed that the tests were failing. I meant to investigate, but it fell off my radar. If you're still interested in getting this merged, could you address the failing tests?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aneilbaboo/replayer/pull/10#issuecomment-303413695, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxSGU1wJcgNZoLat-oFR7u3ALumoPYqks5r8utHgaJpZM4M0QFq .

-- Witek

aneilbaboo commented 7 years ago

Apologies. That bug was introduced on an earlier commit. This PR looks fine. Let me chase down that other bug just to verify, and then I'll get this merged.

aneilbaboo commented 7 years ago

Looks like there was a bug that was printing but silently failing in the examples test script. The bug and the silent failure are fixed in #11 and #12.

Thanks. Merging this now.