anein / angular2-trim-directive

the directive trims whitespaces from the end of an input text value.
MIT License
45 stars 26 forks source link

Safari: cursor moves to the end if you type the symbol at the beginning/middle #36

Closed AlexeyBogdan95 closed 4 years ago

AlexeyBogdan95 commented 5 years ago

In Safari, if you type the symbol at the beginning/middle a cursor usually moves to the end

anein commented 5 years ago

Hi there!

Yes, there's this issue.

AlexeyBogdan95 commented 5 years ago

@anein Actually, I have a branch which contains a fix for this issue, but I can't push it to origin. How can I do it? Thank you!

anein commented 5 years ago

@AlexeyBogdan95 Как обычно. И если есть возможность, то добавь, пожалуйста, тесты, которые проверяют решение. =) https://help.github.com/articles/about-pull-requests/

anein commented 5 years ago

For some reason the solution doesn't pass the tests. =\

Hyuchiha commented 4 years ago

I make a pull request with an improvement of your fix, it passes the test now

anein commented 4 years ago

@Hyuchiha Done and done! Thank you for fixing this old bag. 👍