search

anekos / Ank-Pixiv-Tool

An extension which supports one-click downloads of illustrations from Pixiv. It's able to choose automatically appropriate file names. It also supports full screen view of large illustrations on medium-sized screens.
135 stars 71 forks source link

TypeError While Downloading Single Image #74

Closed CatboyPrincess closed 9 years ago

CatboyPrincess commented 9 years ago

TypeError when downloading single image. Maybe just me?

<<ANK<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< [TypeError] message: path.image.images[0] is undefined filename: chrome://ankpixiv/content/sites/ankpixiv.js linenumber: 334 stack: AnkModule/path.ext@chrome://ankpixiv/content/sites/ankpixiv.js:334 AnkContext@chrome://ankpixiv/content/ankcontext.js:114 AnkBase.downloadCurrentImage@chrome://ankpixiv/content/ankbase.js:724 AnkBase.onDownloadButtonClick@chrome://ankpixiv/content/ankbase.js:2030 onclick@chrome://browser/content/browser.xul:1

Artan1408 commented 9 years ago

I'm having the exact same problem for a few days now. at first I thought it's because I updated firefox (to 34.0.5) but I downgraded (to 33.1.1) and still got the same Error! (only single images have this problem)

<<ANK<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< [TypeError] message: path.image.images[0] is undefined filename: chrome://ankpixiv/content/sites/ankpixiv.js linenumber: 329 stack: AnkModule/path.ext@chrome://ankpixiv/content/sites/ankpixiv.js:329:16 AnkContext@chrome://ankpixiv/content/ankcontext.js:112:1 AnkBase.downloadCurrentImage@chrome://ankpixiv/content/ankbase.js:723:23 AnkBase.onDownloadButtonClick@chrome://ankpixiv/content/ankbase.js:2029:19 oncommand@chrome://browser/content/browser.xul:1:1

Artan1408 commented 9 years ago

nobody can help? after 1 week? is there gonna be an update? :/

d-dd commented 9 years ago

This branch worked for me. https://github.com/anekos/Ank-Pixiv-Tool/tree/fix/does_not_work_in_firefox37

Artan1408 commented 9 years ago

thanks d-dd I downloaded the zip file then compressed source folder into rar, changed it to xpi and renamed it to ankpixiv@snca.net then I replaced it with the old file i had on firefox profile : griknndb.default-1415354192479 -> extensions -> ankpixiv@snca.net (it completely removed ankpixiv and had to install it again) im0f949k.default-1418410241092 -> extensions -> ankpixiv@snca.net (nothing happened, still couldn't download single images) I'm sorry for being a complete noob but did I do this wrong or it didn't work?

d-dd commented 9 years ago

@Artan1408 I use https://addons.mozilla.org/ja/firefox/addon/github-extension-installer/ After installing that, go to https://github.com/anekos/Ank-Pixiv-Tool/tree/fix/does_not_work_in_firefox37/source Click the +Add to Firefox button that appears next to the github folder path.

You may have to delete the old files that you created.

Artan1408 commented 9 years ago

@d-dd I deleted all the old files and did a clean install. but when I click +Add to Firefox I get this error: Error Fetching Package: [error:0]

d-dd commented 9 years ago

@Artan1408 I tried yesterday with a new FF profile, and the steps in my previous message still worked. I'm on FF 34.0.5 by the way. Your error seems to be related to the github-extention-installer addon (because Ank-Pixiv-Tool isn't even installing?) or connection to Github (which I doubt). If you really need to get it working, I would make a new user profile in FF and try again from there (after backing up your current one). Sorry I can't help much further as I'm not very familiar with these tools.

Artan1408 commented 9 years ago

@d-dd I tried again with a new profile and it works perfectly, thank you very much :)

Sodazer0 commented 9 years ago

Thank you very much d-dd Your recipe worked perfekt on the first try.

Now everthing works again. Thank you so much

CatboyPrincess commented 9 years ago

@d-dd << I have tried your solution and it has worked perfectly. Thank you!