search

anelendata / tap-bigquery

Singer.io tap for extracting data from BigQuery tables
Apache License 2.0
16 stars 33 forks source link

Update readme and minor changes #1

Closed sphinks closed 4 years ago

sphinks commented 4 years ago

I try to use this tap to get data from bigquery, but have to fix several issues, so doing backmerge PR.

  1. Fix readme.
  2. Add output of state message to be compatible with any target.
  3. Fix lost require lib in setup script.
daigotanaka commented 4 years ago

@sphinks Thanks for improving the code and docs! Looking good.

daigotanaka commented 4 years ago

@sphinks Can you review this (breaking change v0.3.0) https://github.com/anelendata/tap_bigquery/pull/3 I also wanted to discuss the release on PyPi since you did that with the previous version. Thx!

sphinks commented 4 years ago

@daigotanaka I'm not really good with Python, but I do not notice any issues. Also, I'm not sure I can be mentioned as author yet (just fix couple issues:)), I suppose contributor is much closer to the truth :)

Do you want me to release it on PyPi? Or, I can delete my release on PyPi in case you want to release it by youself.

daigotanaka commented 4 years ago

@sphinks got it about contributor. Can you add me (daigotanaka) as a collaborator at https://pypi.org/manage/project/tap-bigquery/collaboration so I don't have to contact you every time I need to release? Thx!

sphinks commented 4 years ago

@daigotanaka done, you can use it.

daigotanaka commented 4 years ago

Thx @sphinks ! ...also letting you know that I'm changing the repo name to tap-bigquery from tap_bigquery to be consistent with the pypi release name.

sphinks commented 4 years ago

It is make sense!