search

anelendata / tap-bigquery

Singer.io tap for extracting data from BigQuery tables
Apache License 2.0
16 stars 33 forks source link

Allow null datetimes (NoneType) #18

Closed NiallRees closed 3 years ago

NiallRees commented 3 years ago

In all our BigQuery tables, timestamp columns are nullable. This was causing the tap to fail as a NoneType datetime field was raising this ValueError. This PR allows datetime fields to be None.

NiallRees commented 3 years ago

Thanks for the reviews @daigotanaka

daigotanaka commented 3 years ago

@NiallRees Thx! Great job!