anelendata / tap-rest-api

Singer.io tap for generic Rest API
Apache License 2.0
23 stars 14 forks source link

Customize http header #1

Closed daigotanaka closed 4 years ago

daigotanaka commented 4 years ago

Changes look great, this opens up many more options.

I would suggest not to wipe out the default headers, but only to overwrite them if they are present in the config. Either way, the documentation is clear and it's not a big deal.

@aroder Thx for the feedback. I did this way because it's harder for the user to know which headers are predefined internally. Having to redefine User-Agent and Content-type may be redundant, but I prioritized clarity this time.