anentropic / python-waterloo

A cli tool to convert type annotations found in 'Google-style' docstrings into mypy py2 type comments (and from there into py3 type annotations).
2 stars 0 forks source link

Spurious package imports added #43

Closed anentropic closed 3 years ago

anentropic commented 4 years ago

After running waterloo on one file I found these imports:

from rest_framework import serializers
from serializers import Serializer

I believe this is probably the result of originally having:

from rest_framework import serializers

def some_func(arg):
    """
    Args:
        arg (serializers.Serializer)
    """
    ...

...but we already had a matching import and should not have added from serializers import Serializer

anentropic commented 3 years ago

fixed by #46